Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Per-node DataTree chunking #10105

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sjperkins
Copy link

  • Closes Per-node DataTree chunking #9634
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Copy link

welcome bot commented Mar 7, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@sjperkins sjperkins changed the title Initial commit Support Per-node DataTree chunking Mar 7, 2025
@sjperkins sjperkins force-pushed the fine-grained-datatree-chunking branch from 52653bd to 4d5383b Compare March 7, 2025 13:39
@sjperkins
Copy link
Author

Some initial work to support per-node DataTree chunking. It might be this easy (I'm guessing because of all the work @keewis did in #9660), but I've almost certainly missed some subtleties.

One thing that occurred to me was that it's probably worth supporting a default chunk entry, perhaps keyed with "".

I still need to get my head around the mypy errors, but i's EOW for me.

@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-node DataTree chunking
2 participants