Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement Datatree typed ops #9619

Merged
merged 23 commits into from
Oct 15, 2024
Merged

Reimplement Datatree typed ops #9619

merged 23 commits into from
Oct 15, 2024

Commits on Oct 13, 2024

  1. test unary op

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    812d207 View commit details
    Browse the repository at this point in the history

  2. implement and generate unary ops

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1b9c089 View commit details
    Browse the repository at this point in the history

  3. test for unary op with inherited coordinates

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    2d9cef4 View commit details
    Browse the repository at this point in the history

  4. re-enable arithmetic tests

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    4bb8902 View commit details
    Browse the repository at this point in the history

  5. implementation for binary ops

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    8e7c1da View commit details
    Browse the repository at this point in the history

  6. test ds * dt commutativity

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    909ae0e View commit details
    Browse the repository at this point in the history

  7. ensure other types defer to DataTree, thus fixing pydata#9365

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    03ce2c5 View commit details
    Browse the repository at this point in the history

  8. test for inplace binary op

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    12112f1 View commit details
    Browse the repository at this point in the history

  9. pseudocode implementation of inplace binary op, and xfail test

    @TomNicholas
    TomNicholas committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b823290 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. remove some unneeded type: ignore comments

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7147bb3 View commit details
    Browse the repository at this point in the history

  2. return type should be DataTree

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    368d456 View commit details
    Browse the repository at this point in the history

  3. type datatree ops as accepting dataset-compatible types too

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2c740b4 View commit details
    Browse the repository at this point in the history

  4. use same type hinting hack as Dataset does for __eq__ not being same … 

    …as Mapping
    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1eae418 View commit details
    Browse the repository at this point in the history

  5. ignore return type

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bb019da View commit details
    Browse the repository at this point in the history

  6. add some methods to api docs

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    20199cb View commit details
    Browse the repository at this point in the history

  7. don't try to import DataTree.astype in API docs

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7634b6c View commit details
    Browse the repository at this point in the history

  8. test to check that single-node trees aren't broadcast

    @TomNicholas
    TomNicholas committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2814801 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into datatree-ops

    @TomNicholas
    TomNicholas authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1fcbe02 View commit details
    Browse the repository at this point in the history

  2. return NotImplemented

    @TomNicholas
    TomNicholas committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9e2dfad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'datatree-ops' of https://github.com/TomNicholas/xarray … 

    …into datatree-ops
    @TomNicholas
    TomNicholas committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    399c6e1 View commit details
    Browse the repository at this point in the history

  4. remove pseudocode for inplace binary ops

    @TomNicholas
    TomNicholas committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    304eb19 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into datatree-ops

    @TomNicholas
    TomNicholas committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7dbc817 View commit details
    Browse the repository at this point in the history

  6. map_over_subtree -> map_over_datasets

    @TomNicholas
    TomNicholas committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c7d8060 View commit details
    Browse the repository at this point in the history