Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster chunk checking for backend datasets #9808

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Faster chunk checking for backend datasets #9808

wants to merge 4 commits into from
+45 −19

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Nov 21, 2024 •
edited
Loading

@dcherian dcherian mentioned this pull request Nov 21, 2024
Closed
@dcherian dcherian marked this pull request as draft November 21, 2024 18:47
@dcherian dcherian added the topic-chunked-arrays Managing different chunked backends, e.g. dask label Nov 21, 2024
@dcherian dcherian force-pushed the cache-chunking-backend-dataset branch from 8e80fb9 to e2aad24 Compare November 21, 2024 18:59
@dcherian dcherian marked this pull request as ready for review November 21, 2024 19:07
max-sixty
max-sixty approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't re-think through the logic but the cache idea makes sense, thanks!

@dcherian dcherian added the plan to merge Final call for comments label Nov 21, 2024
@dcherian
Copy link
Contributor Author

I didn't re-think through the logic but the cache idea makes sense, thanks!

The core of it didn't change, just avoided materializing a huge iterable in memory in favor of finding the first disagreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-chunked-arrays Managing different chunked backends, e.g. dask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opening a zarr dataset taking so much time
2 participants
@dcherian @max-sixty