Skip to content

Commit

Permalink
Minor updates from master (#735)
Browse files Browse the repository at this point in the history
  • Loading branch information
scaramallion authored Jan 5, 2022
1 parent b2f065d commit fed0326
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/publish-pypi-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ jobs:
pip install -i https://test.pypi.org/simple/ pynetdicom
- name: Test with pytest
env:
PYTHON_VERSION: ${{ matrix.python-version }}
run: |
cd ${HOME}
python -m pynetdicom --version
Expand Down
1 change: 1 addition & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ Applications
Release Notes
=============

* :doc:`v2.0.1 </changelog/v2.0.1>`
* :doc:`v2.0.0 </changelog/v2.0.0>`
* :doc:`v1.5.7 </changelog/v1.5.7>`
* :doc:`v1.5.6 </changelog/v1.5.6>`
Expand Down
3 changes: 1 addition & 2 deletions pynetdicom/ae.py
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ def associate(
.. versionchanged:: 2.0
* `ae_title` should now be :class:`str`
* The default `bind_address` was changed to ``("127.0.0.1", 0)``
Parameters
----------
Expand Down Expand Up @@ -526,7 +525,7 @@ def associate(
* :class:`~UserIdentityNegotiation` (0 or 1 item)
bind_address : 2-tuple, optional
The (host, port) to bind the association's communication socket
to, default ``("127.0.0.1", 0)``.
to, default ``("", 0)``.
tls_args : 2-tuple, optional
If TLS is required then this should be a 2-tuple containing a
(`ssl_context`, `server_hostname`), where `ssl_context` is the
Expand Down
10 changes: 3 additions & 7 deletions pynetdicom/transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@ def __init__(
) -> None:
"""Create a new :class:`AssociationSocket`.
.. versionchanged:: 2.0
The default for *address* was changed to ``("127.0.0.1", 0)``
Parameters
----------
assoc : association.Association
Expand All @@ -156,7 +152,7 @@ def __init__(
address : 2-tuple, optional
If *client_socket* is ``None`` then this is the ``(host, port)`` to
bind the newly created socket to, which by default will be
``('127.0.0.1', 0)``.
``("", 0)``.
"""
self._assoc = assoc

Expand Down Expand Up @@ -213,7 +209,7 @@ def close(self) -> None:
self.event_queue.put("Evt17")

def connect(self, primitive: T_CONNECT) -> None:
"""Try and connect to a remote at `address`.
"""Try and connect to a remote using connection details from `primitive`.
.. versionchanged:: 2.0
Expand Down Expand Up @@ -288,7 +284,7 @@ def _create_socket(self, address: Tuple[str, int] = BIND_ADDRESS) -> socket.sock
----------
address : 2-tuple, optional
The ``(host: str, port: int)`` to bind the socket to. By default the socket
is bound to ``("127.0.0.1", 0)``, i.e. the first available port.
is bound to ``("", 0)``, i.e. the first available port.
Returns
-------
Expand Down

0 comments on commit fed0326

Please sign in to comment.