Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Assorted CI fixes #865

Merged
merged 3 commits into from
Oct 8, 2023
Merged

[MRG] Assorted CI fixes #865

merged 3 commits into from
Oct 8, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 8, 2023 •
edited
Loading

Reference issue

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

@DimitriPapadopoulos DimitriPapadopoulos changed the title [MRG] Fix typos and ignore false poositives found by codespell [MRG] Fix typos and ignore false positives found by codespell Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #865 (b1fffd4) into master (2aa9ed7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #865   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8639      8639           
=========================================
  Hits          8639      8639
Files Coverage Δ
pynetdicom/_handlers.py 100.00% <ø> (ø)

@DimitriPapadopoulos DimitriPapadopoulos changed the title [MRG] Fix typos and ignore false positives found by codespell [MRG] Assorted CI fixes Oct 8, 2023
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Oct 8, 2023
Merged
6 tasks
@mrbean-bremen mrbean-bremen merged commit ca798a7 into pydicom:master Oct 8, 2023
14 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch October 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen mrbean-bremen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @mrbean-bremen