Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] {str(x)}{x} #867

Merged
merged 1 commit into from
Oct 8, 2023
Merged

[MRG] {str(x)}{x} #867

merged 1 commit into from
Oct 8, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 8, 2023

Casting to str is redundant, it is the default.

From Format Specification Mini-Language:

A general convention is that an empty format specification produces the same result as if you had called str() on the value. A non-empty format specification typically modifies the result.

Reference issue

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #867 (022e9ed) into master (ca798a7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8639      8639           
=========================================
  Hits          8639      8639           
Files Coverage Δ
pynetdicom/service_class.py 100.00% <ø> (ø)

@DimitriPapadopoulos DimitriPapadopoulos changed the title {str(x)}{x} [MRG] {str(x)}{x} Oct 8, 2023
@mrbean-bremen mrbean-bremen merged commit 708ccda into pydicom:master Oct 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants