Update shift_location for origin-wrapping feature with strand None #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @BjornFJohansson I think this should be the expected behaviour (
strand = None
same asstrand = +1
). See the example below, for a feature that wraps around the origin in a molecule of length 12:Output is:
I think for
strand == None
it should bejoin{[10:12], [0:2]}
which more clearly shows the origin-wrapping nature of the feature.The tests that fail are the same ones as before the change, so I don't think this breaks anything in the tests