Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints for add_collection #1012

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix type hints for add_collection #1012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a47383
Fix type hints for add_collection
jamesmyatt Nov 5, 2024
60c3050
Update collection.py
jamesmyatt Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions invoke/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import copy
from types import ModuleType
from typing import Any, Callable, Dict, List, Optional, Tuple
from typing import Any, Callable, Dict, List, Optional, Tuple, Union

from .util import Lexicon, helpline

Expand Down Expand Up @@ -284,14 +284,16 @@ def add_task(

def add_collection(
self,
coll: "Collection",
coll: Union["Collection", ModuleType],
name: Optional[str] = None,
default: Optional[bool] = None,
) -> None:
"""
Add `.Collection` ``coll`` as a sub-collection of this one.

:param coll: The `.Collection` to add.
:param coll:
The `.Collection` to add. A `ModuleType` will be converted to a
`.Collection` using `.Collection.from_module`.

:param str name:
The name to attach the collection as. Defaults to the collection's
Expand Down