-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murnaghan: Round children names #1121
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 6232695844
💛 - Coveralls |
I'm actually not sure if we should define |
Am open to that as well. I kind of like seeing the strain in the job name, though, because you tell quickly which ones e.g. failed. |
But is it really possible to see the problem by looking at the strain value? |
Not often, but I just find it generally informative. |
Ok then at least I would like to make the job name function accessible from outside, because I might want to get the data based on the strain values. |
Not sure what you mean. So that I can set a function from outside that determines the child names? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When the job name of the murnaghan is long; using ~10 digits for the strain can blow the job name limit. So I added some rounding here.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When the job name of the murnaghan is long; using ~10 digits for the strain can blow the job name limit. So I added some rounding here.
The PR helps, but doesn't allow to influence the rounding. Since
Murnaghan
job knows how much to safely round, this PR takes advantage of this here.Alternatively one could drop the murnaghan job name from the names of the children. It's redundant, but I thought it might be a larger change, in that users will see their jobs changing. I feel ambivalent about this though.