Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murnaghan: Round children names #1121

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Murnaghan: Round children names #1121

wants to merge 1 commit into from

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Jul 25, 2023

When the job name of the murnaghan is long; using ~10 digits for the strain can blow the job name limit. So I added some rounding here.

The PR helps, but doesn't allow to influence the rounding. Since Murnaghan job knows how much to safely round, this PR takes advantage of this here.

Alternatively one could drop the murnaghan job name from the names of the children. It's redundant, but I thought it might be a larger change, in that users will see their jobs changing. I feel ambivalent about this though.

@pmrv pmrv added bug Something isn't working enhancement New feature or request labels Jul 25, 2023
@pmrv pmrv requested a review from samwaseda July 25, 2023 12:30
@coveralls
Copy link

coveralls commented Jul 25, 2023

Pull Request Test Coverage Report for Build 6232695844

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.302%

Totals Coverage Status
Change from base Build 6221151764: 0.02%
Covered Lines: 10750
Relevant Lines: 15739

💛 - Coveralls

@pmrv pmrv added the integration Start the notebook integration tests for this PR label Jul 25, 2023
@samwaseda
Copy link
Member

I'm actually not sure if we should define job_name in the first place in Murnaghan. At least I don't see why we shouldn't simply use the default job_name from JobGenerator everywhere.

@pmrv
Copy link
Contributor Author

pmrv commented Jul 27, 2023

Am open to that as well. I kind of like seeing the strain in the job name, though, because you tell quickly which ones e.g. failed.

@samwaseda
Copy link
Member

But is it really possible to see the problem by looking at the strain value?

@pmrv
Copy link
Contributor Author

pmrv commented Jul 27, 2023

Not often, but I just find it generally informative.

@samwaseda
Copy link
Member

Ok then at least I would like to make the job name function accessible from outside, because I might want to get the data based on the strain values.

@pmrv
Copy link
Contributor Author

pmrv commented Aug 2, 2023

Ok then at least I would like to make the job name function accessible from outside, because I might want to get the data based on the strain values.

Not sure what you mean. So that I can set a function from outside that determines the child names?

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
When the job name of the murnaghan is long; using ~10 digits for the strain can blow the job name limit.
So I added some rounding here.
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@jan-janssen jan-janssen marked this pull request as draft February 14, 2024 15:18
@stale stale bot removed the stale label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request integration Start the notebook integration tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants