Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyiron/actions target #25

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update pyiron/actions target #25

merged 1 commit into from
Jul 23, 2024

Conversation

liamhuber
Copy link
Member

Also to test the developments there across a real system, so I'll later force-push a commit for the actual release tag to clean the history here.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_snippets/update_ci

Copy link

codacy-production bot commented Jul 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (caa505a) 551 523 94.92%
Head commit (375d8fb) 551 (+0) 523 (+0) 94.92% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#25) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jul 23, 2024

Pull Request Test Coverage Report for Build 10066149677

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.918%

Totals Coverage Status
Change from base Build 10044891699: 0.0%
Covered Lines: 523
Relevant Lines: 551

💛 - Coveralls

@liamhuber
Copy link
Member Author

For the run creating and caching new envs, everything went smoothly (including getting the correct versions of python throughout) except for windows, which strangely fails at which conda, even though setup miniconda ran successfully.

@liamhuber liamhuber closed this Jul 23, 2024
@liamhuber liamhuber reopened this Jul 23, 2024
@liamhuber liamhuber closed this Jul 23, 2024
@liamhuber liamhuber reopened this Jul 23, 2024
@liamhuber
Copy link
Member Author

Super, versioning and everything looks good. Let's close and reopen once more to check when the cache loads.

@liamhuber liamhuber closed this Jul 23, 2024
@liamhuber liamhuber reopened this Jul 23, 2024
@liamhuber
Copy link
Member Author

Not bad; for such a simple env loading the cache is not enormously helpful, but it's not too bad. Approximately:

  • Ubuntu: 40s -> 30s
  • Windows: 2.5m -> 2.25m
  • OSX: 1.5m -> 1m

Preliminary tests over on pyiron/actions showed that the speedup is better for more complex envs (obviously, as the solve step takes longer relative to downloading), so remember to take a peek at these again over on pyiron_workflow.

@liamhuber liamhuber closed this Jul 23, 2024
@liamhuber liamhuber reopened this Jul 23, 2024
@liamhuber liamhuber merged commit 4d26756 into main Jul 23, 2024
19 checks passed
@liamhuber liamhuber deleted the update_ci branch July 23, 2024 20:50
@liamhuber liamhuber restored the update_ci branch July 23, 2024 20:56
@liamhuber liamhuber deleted the update_ci branch July 23, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants