Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclass interface to spglib symmetry #247

Closed
wants to merge 2 commits into from
Closed

Use dataclass interface to spglib symmetry #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d92ea2c
Use dataclass interface to spglib symmetry
pmrv Aug 27, 2024
e9e4120
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions structuretoolkit/analyse/symmetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Distributed under the terms of "New BSD License", see the LICENSE file.

import ast
import dataclasses
import string
from functools import cached_property
from typing import Optional
Expand Down Expand Up @@ -65,8 +66,8 @@ def __init__(
self._angle_tolerance = angle_tolerance
self.epsilon = epsilon
self._permutations = None
for k, v in self._get_symmetry(
symprec=symprec, angle_tolerance=angle_tolerance
for k, v in dataclasses.asdict(
self._get_symmetry(symprec=symprec, angle_tolerance=angle_tolerance)
).items():
self[k] = v

Expand Down
Loading