[Feature] User Creation and Login #16
Conversation
|
Please specify in the readme.MD how another developer can run your project |
|
And.. How can I test the feature that you added? |
|
@lubegamark, Please review |
|
@Dru94 Very Good work so far. I changed the base branch to |
| @@ -0,0 +1,3 @@ | |||
| from django.test import TestCase | |||
|
|
|||
| # Create your tests here. | |||
There was a problem hiding this comment.
@Dru94 could you add a few tests
| from django.contrib.auth.views import LoginView,LogoutView, PasswordResetView, PasswordResetDoneView, \ | ||
| PasswordResetConfirmView, PasswordResetCompleteView | ||
|
|
||
| urlpatterns=[ |
There was a problem hiding this comment.
@Dru94 what do you think about using social login instead, I'm thinking maybe GitHub and Google. I suggest you use Django Allauth but you can suggest any other package that does the same thing
| return render(request, 'base.html') | ||
|
|
||
| #registration view | ||
| def reg(request): |
There was a problem hiding this comment.
@Dru94 use proper function names, reg should be register, I know there's a comment that says registration view but code should be self documenting and require very little comments
Login and registration feature