Feature/filters product list #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoor
requested changes
Feb 14, 2024
yanazPL
reviewed
Feb 18, 2024
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(ProductFilter, self).__init__(*args, **kwargs) | ||
| self.filters['name'].label = 'Nazwa produktu' |
There was a problem hiding this comment.
Not sure if those are needed. labels already defined here:
field_labels={
'price': 'Cena rosnąco',
'-price': 'Cena malejąco',
'-name': 'Produkt A-Z',
'name': 'Produkt Z-A',
'created_at': 'Najnowsze',
'-created_at': 'Najstarsze',
},There was a problem hiding this comment.
I don't know if it's okay either, but I need the eye of an experienced programmer @jacoor
There was a problem hiding this comment.
Ha. I don't know :-)
You need to experiment with it and see if it works as intended or is needed.
That's what I would do.
|
I just added the newest, the oldest product order filters. Also availability filters have been added. Tests of |
|
@Pawelooo you need to update from dev. |
…Dshop into feature/filters-product-list
|
I updated branch from dev, so pull. |
jacoor
requested changes
Feb 26, 2024
|
|
||
|
|
||
|
|
||
| # @pytest.mark.django_db |
There was a problem hiding this comment.
Please remove those comments
|
@jacoor updated |
jacoor
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a search for products only on active ones. I don't know if it's not enough to search for not active products ?
At Orderingfilter, he returns Z-A products first and not the A-Z product first
A-Z product
Product with Z-A and next Product A-Z