Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dustin Stansbury's statistical rethinking notebooks #754

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Dec 17, 2024

Adds Dustin's notebooks to the examples, adapting the style accordingly.

Helpful links


📚 Documentation preview 📚: https://pymc-examples--754.org.readthedocs.build/en/754/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fonnesbeck fonnesbeck marked this pull request as ready for review December 17, 2024 23:14
@fonnesbeck
Copy link
Member Author

@dustinstansbury Hey Dustin, thanks for allowing us to add your Rethinking notebooks to our examples gallery! Please have a peek at this PR and see if this works for you. I've mainly edited the very start and very end of each notebook, to make headers, etc. consistent with the rest of the site. That basically involved pulling code out of your initialization script and placing them directly in the notebooks, and adding attribution to you and McElreath. I've included your original license file in the subdirectory.

@jessegrabowski
Copy link
Member

I pushed a commit that sorts notebooks by the raw name before rendering the gallery. This puts the rethinking notebooks in order, but it also reshuffles all the other categories. I don't personally mind for two reasons:

  1. It appears the over we previous got was semi-random
  2. If we don't like the new ordering, we can rename notebooks with number prefixes like 01_introduction, 02_dimensionality, 03_linear_regression. This also makes it obvious what the ordering is supposed to be.

Happy to be over-ruled on this though.

What do you think of putting the lecture numbers in the titles of the notebooks that are displayed in the gallery? That would make it more obvious the order that one is supposed to view them in.

@fonnesbeck fonnesbeck requested a review from AlexAndorra January 4, 2025 15:15
@fonnesbeck
Copy link
Member Author

Yeah, I can change the titles (and the file names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants