-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule redesign #105
base: gh-pages
Are you sure you want to change the base?
Schedule redesign #105
Conversation
Wow this looks nice. I have a bunch of nits but overall this looks so clean.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions listed above. After this batch of changes theres a couple more I'll ask about
UTC+0 and UTC-7 are now listed on separate lines. Other requests were also addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! I don't know what kind of magic is going on but I'm loving it.
I requested a change regarding the navbar and the metadata (otherwise we won't get cards nor analytics for this page for example). I realize it used different fonts than the rest of the page, but perhaps it would be better to use these fonts everywhere (thus editing head.html) instead of having this page differ.
I added a comment about Chris Q&A, Aki's one is missing, but I'm not sure when will it be so for now it's still in the air, @canyon289 ?
<link href="../schedule_files/font-awesome.css" rel="stylesheet"> | ||
<link href="../schedule_files/streamline-icons.css" rel="stylesheet"> | ||
|
||
<!-- Our styles --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should take advantage of the layouts and include files there are available. Take a look for example at the source code of the home page: https://github.com/pymc-devs/pymcon/blob/gh-pages/_layouts/2017_home.html or the code of conduct page: https://github.com/pymc-devs/pymcon/blob/gh-pages/_2017_pages/code_of_conduct.html.
I'd recommend creating a schedule layout based on the 2017_default
to split layout (css styles mostly) and content. Moreover, this layout will include head, header, js and footer which should be common in all pages (head for base style and metadata and analytics, header for the navbar, footer for copyright and contact links...).
Including head and header is a must, splitting the content into the two layout/content files is not, I understand it takes some time and we currently don't have plans to use this layout anywhere else so the improvement is only regarding readablility and the ability for anyone to edit the schedule (i.e. Aki's Q&A)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the bandwidth to look into mixing and matching metadata and navbar.
This is as far as I can take the redesign
Yes I need to move Akis keynote into previous timezone, unfortunately need to make that change ahead of this merge given the proximity to the conference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now but want to be sure I'm not missing anything. @sidravi1 @OriolAbril can either of you review and make sure there's no big mistakes?
One last piece of help, can this be changed to social hour to match the european track? I know I made the mistake on the original schedule, just figure by now we should correct it 🤦
Ah actually I realized one major issue is that sprints are not included anywhere and its critical that people know when they are, because they are part of the schedule after all. We cant merge this until we have a way to showcase that timing. Will we be able to add that to this revised schedule? |
I thought sprints were the 10 minute speaker sessions. Are the sprints something else? |
Theyre something else. The speaker session are the Q&A. The sprints are a
place for people to learn how to contribute to PyMC
…On Mon, Oct 26, 2020 at 11:20 PM Alvin Thai ***@***.***> wrote:
I thought sprints were the 10 minute speaker sessions. Are the sprints
something else?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXBFYN7JDUN73V2QB6HKKLSMZRD5ANCNFSM4S6R3B6A>
.
|
I had to merge this one ahead. I'm sorry for the conflict. Due to the proximity of the conference I'm getting nervous merging this as the primary schedule given were 3 days out |
Oh I didn't know that about the sprints. What is "Room 1" and are the other tracks in different "rooms"? |
For the sprints, I am thinking about linking the Beginner Zone's directly towards this link: Sound good? EDIT: I thought the beginner zone was a sprint, but I'm guessing it's not. |
Each room in the original schedule is a different webex event. Thus, if there is one column only, there will be only one streaming/meeting happening at once, if there are 3 there will be 3 streamings/meeting happening at the same time.
Indeed, the begginer zone is not the same as the sprints. I would not add a link to the beginer zone from the schedule as it's mostly async. The schedule should show when will sprints happen as they don't happen during the whole live session nor happen only on zulip. Moreover, we should not share links to zulip streams. They will only work for people who already have a zulip account on the pymcon organization. Attendees will receive their invites in the coming days. |
I created a |
ok, well if you want to see how it renders on my local gh pages, see below |
No description provided.