Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont check input alias on Function call #1049

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 25, 2024

Follow up to #1024 and closes #1026


📚 Documentation preview 📚: https://pytensor--1049.org.readthedocs.build/en/1049/

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (a377c22) to head (69d0dd9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/compile/function/types.py 90.90% 3 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   81.90%   81.93%   +0.02%     
==========================================
  Files         182      182              
  Lines       47879    47851      -28     
  Branches     8617     8608       -9     
==========================================
- Hits        39214    39205       -9     
+ Misses       6492     6476      -16     
+ Partials     2173     2170       -3     
Files with missing lines Coverage Δ
pytensor/compile/io.py 83.01% <ø> (ø)
pytensor/gradient.py 77.57% <ø> (+0.07%) ⬆️
pytensor/graph/null_type.py 64.70% <ø> (+1.54%) ⬆️
pytensor/graph/op.py 88.08% <100.00%> (+0.06%) ⬆️
pytensor/graph/type.py 93.65% <100.00%> (-0.20%) ⬇️
pytensor/scalar/basic.py 80.52% <ø> (+0.01%) ⬆️
pytensor/tensor/random/op.py 93.51% <100.00%> (-0.21%) ⬇️
pytensor/tensor/type_other.py 74.41% <ø> (+0.26%) ⬆️
pytensor/compile/function/types.py 79.47% <90.90%> (-0.47%) ⬇️

... and 3 files with indirect coverage changes

@ricardoV94 ricardoV94 marked this pull request as draft November 29, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider checking for input alias during function calls
1 participant