Added dot kron rewrite #1090
Open
Added dot kron rewrite #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 183 183
Lines 47959 47972 +13
Branches 8635 8636 +1
=======================================
+ Hits 39381 39394 +13
Misses 6411 6411
Partials 2167 2167
|
jessegrabowski
requested changes
Nov 17, 2024
| @register_canonicalize | ||
| @register_stabilize | ||
| @node_rewriter([Dot]) | ||
| def rewrite_dot_kron(fgraph, node): |
There was a problem hiding this comment.
Needs a docstring and typehints
| @@ -906,3 +906,29 @@ def test_rewrite_cholesky_diag_to_sqrt_diag_not_applied(): | |||
| f_rewritten = function([x], z_cholesky, mode="FAST_RUN") | |||
| nodes = f_rewritten.maker.fgraph.apply_nodes | |||
| assert any(isinstance(node.op, Cholesky) for node in nodes) | |||
|
|
|||
|
|
|||
| def test_dot_kron_rewrite(): | |||
There was a problem hiding this comment.
Add test with batch dims. I am worried the use of e.g. ravel in the rewrite will cause problems.
|
The name I found for the identity we're exploiting here is vec-trick, so we can use that in the naming instead of "clever way", which doesn't say anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a rewrite for kron(a,b) @ c -> (b @ c.reshape @ a.T).ravel
Related Issue
dot(kron(a, b), c)#1043Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1090.org.readthedocs.build/en/1090/