-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci-requirements): create an environment YAML config for CI tests (Ubuntu) #449 #538
base: main
Are you sure you want to change the base?
Conversation
@ricardoV94 should we have different yml files for each platform we test on? See here as a template to follow. |
@jessegrabowski I was wondering what to call the dir I put the yml config in! Will change and then review the CI workflow for other platforms to target in the same fashion. You already have an |
I'm not sure if that environment.yml is used for much, it looks like docs only from a quick search? I would support getting rid of it entirely. |
I've now covered the benchmark environment and the other numba & jax environment config files too. (09b8a01) |
Any issue with putting these inside the .github/workflows directory? |
PyMC puts them in their own folder here; the PR was this way at my recommendation. I guess there's no reason why they couldn't be in the .github folder instead, just for consistency between the packages? |
PyMC ones are sometimes recommended for devs, but here we are not doing that, so I would keep the root folder uncluttered. Not a strong preference though |
Motivation for these changes
As requested in:
Implementation details
You can specify both a package positional argument and (one or more)
--file
/-f
argument which points to a conda format environment yml or traditional txt requirements file.Initially I just did the Ubuntu test env pointed to in the issue (#449)
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance