refactor!: change axis_order type to Tuple[str, ...]
#140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #138
Changes:
the typing of
MDASequence.axis_order
was too strict. It's fine to accept a string as input, but it should also be able to accept a sequence of strings, each of which may be more than a single character@ianhi, can you think of anywhere you're assuming axis_order is a literal string, rather than generic sequence of strings?