Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for pydantic 2.10 #203

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

tlambert03
Copy link
Member

Pydantic 2.10 broke importing of useq-schema. You'll see this error:

.venv/lib/python3.12/site-packages/pydantic/_internal/_generate_schema.py:817: in _resolve_forward_ref
    raise PydanticUndefinedAnnotation.from_name_error(e) from e
E   pydantic.errors.PydanticUndefinedAnnotation: name 'Annotated' is not defined
E
E   For further information visit https://errors.pydantic.dev/2.10/u/undefined-annotation

this PR fixes it, and should be released ASAP

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (f61cad9) to head (145692b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          18       18           
  Lines        1238     1239    +1     
=======================================
+ Hits         1161     1162    +1     
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tlambert03 tlambert03 merged commit 569c207 into pymmcore-plus:main Nov 20, 2024
26 checks passed
@tlambert03 tlambert03 deleted the fix-pydantic branch November 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant