-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for constraints, install in topological order #177
Conversation
Looks nice so far I suppose the next step would be to actually use them. |
846ed37
to
e50f58c
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some comment
Had a thought which might skip all the bookkeeping: still do |
I think #181 is the better way forward, but will keep this open as a draft for reference. |
Closing in favor of #181 |
references
changes
micropip.set_constraints
constraints
to the signatures ofinstall
andTransaction
install
to handle constrained indirect dependencies of packages found inpyodide-lock.json
requested_by
to the signatures of manyTransaction
methodsTransaction.dependency_graph
breaking changes
hopefully none, as it's opt-in, and only adds keyword-only arguments to the already very finickyinstall
, etc.pyodide-lock.json
were unconditionally installed before any resolved wheels