Allow dynamic imports in node selenium code #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since node v20 we can pass `importModuleDynamically` to allow dynamic imports in code run by `vm.runInContext`. In older node versions, we fall back to the old behavior. Co-Authored-By: Antonio Cuni <[email protected]>
hoodmane
force-pushed
the
allow-dynamic-import
branch
from
ebbedb3 to
2bc222b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since node v20 we can pass
importModuleDynamicallyto allow dynamic imports in code run byvm.runInContext. In older node versions, we fall back to the old behavior.Tested manually.