-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] Fixing target plots #851
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #851 +/- ##
==========================================
- Coverage 78.32% 78.25% -0.08%
==========================================
Files 140 139 -1
Lines 16232 16228 -4
==========================================
- Hits 12714 12699 -15
- Misses 3518 3529 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
bioptim/limits/penalty.py
line 97 at r1 (raw file):
to_first=list(range(controller.get_nlp.controls[key].cx_start.shape[0])), to_second=list(range(controller.get_nlp.controls[key].cx_start.shape[0])), ) # TODO: why if condition, target_mapping not used (Pariterre?)
This is done elsewhere, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pariterre)
bioptim/limits/penalty.py
line 97 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
This is done elsewhere, isn't it?
Yes, what I just did fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is