Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] Fixing target plots #851

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Feb 23, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request? Issue Plot errors in multi-phase #781
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.25%. Comparing base (e54be49) to head (7494252).
Report is 48 commits behind head on master.

Files Patch % Lines
bioptim/limits/penalty_option.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   78.32%   78.25%   -0.08%     
==========================================
  Files         140      139       -1     
  Lines       16232    16228       -4     
==========================================
- Hits        12714    12699      -15     
- Misses       3518     3529      +11     
Flag Coverage Δ
unittests 78.25% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


bioptim/limits/penalty.py line 97 at r1 (raw file):

                    to_first=list(range(controller.get_nlp.controls[key].cx_start.shape[0])),
                    to_second=list(range(controller.get_nlp.controls[key].cx_start.shape[0])),
                )  # TODO: why if condition, target_mapping not used (Pariterre?)

This is done elsewhere, isn't it?

@EveCharbie EveCharbie changed the title Fixing target plots [RTR] Fixing target plots Feb 23, 2024
This was referenced Feb 23, 2024
Copy link
Collaborator Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pariterre)


bioptim/limits/penalty.py line 97 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

This is done elsewhere, isn't it?

Yes, what I just did fixed it.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit b2b9e6b into pyomeca:master Feb 23, 2024
22 of 24 checks passed
@EveCharbie EveCharbie deleted the plots_targets branch May 29, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants