Diagnostic Error for Resolution Too Deep #13282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional documentation and a diagnostic error when ResolutionTooDeep is thrown from resolvelib.
Further, it points users, who have read the documentation, to the issue #13281 that I would like to maintain and use to collect reports of ResolutionTooDeep.
I am motivated both for collecting these kind of errors in general from users because I'm worried they have been under reported, and because resolvelib 1.1.0 makes these errors more likely for some complex requirements.
The error looks like this:
I appreciate I am doing a couple of extra things here compared to normal, feedback welcome.