Fix "residual" invalid dynamic behaviour of optional-dependencies
#4696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is reminiscent of #3306.
It is another situation where PEP 621 does not allow mixing dynamic and static configurations.
Without explicitly listing
optional-dependencies
indynamic
users cannot rely onsetup.py
to specifyextras_require
-- in turn, whenoptional-dependencies
is present indynamic
, then it cannot be listed as an static configuration.Therefore, the only valid situation according to PEP 621, is that static
optional-dependencies
are honoured exactly as provided, without modifications (this means ignoring anyextras_require
previously set)..Closes #3300
Pull Request Checklist
newsfragments/
.(See documentation for details)