-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PySimpleGUI versions 4 and 5 as a Framework #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an obvious addition, given the popularity of PySimpleGUI. Approved!
Am I missing some required information? Lemme see if this is a secret phrase as it worked for the last approved pull request.
[ EDIT ] In case it doesn't come through... this was meant as humor 😉 I know people are busy. |
Please see the linting failures. |
DOH! Sorry about the botched sort. Thank you very much @di! I think I fixed it correctly. |
…f these still....
When do these changes show up on the PyPI site / become usable by packages being uploaded? |
Now that they have been merged and a release containing the changes has been published, it takes a day or two for Dependabot to suggest the change to warehouse, and then it might take a few days for us to merge it in. However I believe these have been merged already - as part of pypi/warehouse#14914 |
When the dependency gets update on PyPI, which has happened: https://github.com/pypi/warehouse/blob/d74fff4e3d89b136fec5e17c180620c9cfcef0f3/requirements/main.txt#L1628-L1631 However looks like we had a deployment failure: https://github.com/pypi/warehouse/actions/runs/6867233971/attempts/1 |
You should now see these classifiers here, which means they're good to use: https://pypi.org/classifiers/ |
Request to add a new Trove classifier.
The name of the classifier(s) you would like to add:
Why do you want to add this classifier?
PySimpleGUI, the popular GUI framework for Python, is about to ship a major upgrade. PySimpleGUI 5 features significant enhancements, including new features, new tools, and new support plans. PyPi users will find value in being able to distinguish between the various versions, and the best mechanism is to add distinctive classifiers.