Default behaviour change to write ensembles to dense format when ensemble size > 1e6 #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes default behaviour to write ensembles to dense binary format when the number of obs or parameters exceeds 1e6.
This is consistent with changes coming in PEST++ and favours the dense binary format for more reliable and faster IO when the ensembles get big.
USERS BEWARE: Will add a '.bin' extension to the requested filename if nobs or npars exceeds 1e6. Happy to discuss alternative options -- like error raising, or agnostically propagating filename but this seems the safest and leas disruptive.
Ensemble.to_binary()
should now return the written filename.