Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behaviour change to write ensembles to dense format when ensemble size > 1e6 #584

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

briochh
Copy link
Collaborator

@briochh briochh commented Apr 3, 2025

This PR changes default behaviour to write ensembles to dense binary format when the number of obs or parameters exceeds 1e6.

This is consistent with changes coming in PEST++ and favours the dense binary format for more reliable and faster IO when the ensembles get big.

USERS BEWARE: Will add a '.bin' extension to the requested filename if nobs or npars exceeds 1e6. Happy to discuss alternative options -- like error raising, or agnostically propagating filename but this seems the safest and leas disruptive. Ensemble.to_binary() should now return the written filename.

@briochh briochh requested a review from jtwhite79 April 3, 2025 00:07
@coveralls
Copy link

Coverage Status

coverage: 79.088% (+0.2%) from 78.91%
when pulling ca340d2 on briochh:feat_densedefault
into b8d6033 on pypest:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants