Skip to content

Commit

Permalink
remove max_value
Browse files Browse the repository at this point in the history
  • Loading branch information
@jschlyter
jschlyter committed Dec 8, 2024
1 parent a2017b2 commit 131680e
Showing 1 changed file with 0 additions and 53 deletions.
53 changes: 0 additions & 53 deletions custom_components/polestar_api/sensor.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class PolestarSensorDescriptionMixin:
"""Define an entity description mixin for sensor entities."""

round_digits: int | None
max_value: int | None


@dataclass
Expand Down Expand Up @@ -73,7 +72,6 @@ class PolestarSensorDescription(
round_digits=2,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DISTANCE,
max_value=660,
),
PolestarSensorDescription(
key="current_odometer",
Expand All @@ -85,7 +83,6 @@ class PolestarSensorDescription(
round_digits=2,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DISTANCE,
max_value=1000000000,
),
PolestarSensorDescription(
key="average_speed",
Expand All @@ -95,7 +92,6 @@ class PolestarSensorDescription(
round_digits=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.SPEED,
max_value=150,
),
PolestarSensorDescription(
key="current_trip_meter_automatic",
Expand All @@ -106,7 +102,6 @@ class PolestarSensorDescription(
round_digits=2,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DISTANCE,
max_value=100000,
),
PolestarSensorDescription(
key="current_trip_meter_manual",
Expand All @@ -117,7 +112,6 @@ class PolestarSensorDescription(
round_digits=2,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DISTANCE,
max_value=100000,
),
PolestarSensorDescription(
key="battery_charge_level",
Expand All @@ -126,23 +120,20 @@ class PolestarSensorDescription(
round_digits=0,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.BATTERY,
max_value=100,
),
PolestarSensorDescription(
key="estimated_charging_time_to_full",
name="Charging Time",
icon="mdi:battery-clock",
native_unit_of_measurement=UnitOfTime.MINUTES,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="charging_status",
name="Charging Status",
icon="mdi:ev-station",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="charging_power",
Expand All @@ -151,7 +142,6 @@ class PolestarSensorDescription(
native_unit_of_measurement=UnitOfPower.WATT,
suggested_display_precision=0,
round_digits=None,
max_value=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.POWER,
),
Expand All @@ -162,7 +152,6 @@ class PolestarSensorDescription(
native_unit_of_measurement=UnitOfElectricCurrent.AMPERE,
suggested_display_precision=0,
round_digits=None,
max_value=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.CURRENT,
),
Expand All @@ -172,7 +161,6 @@ class PolestarSensorDescription(
icon="mdi:connection",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
device_class=None,
),
PolestarSensorDescription(
Expand All @@ -182,7 +170,6 @@ class PolestarSensorDescription(
native_unit_of_measurement="kWh/100km",
suggested_display_precision=1,
round_digits=None,
max_value=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=None,
),
Expand All @@ -192,7 +179,6 @@ class PolestarSensorDescription(
icon="mdi:battery-clock",
native_unit_of_measurement=UnitOfTime.MINUTES,
round_digits=None,
max_value=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=None,
),
Expand All @@ -202,15 +188,13 @@ class PolestarSensorDescription(
icon="mdi:card-account-details",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="software_version",
name="Software Version",
icon="mdi:information-outline",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="software_version_release",
Expand All @@ -220,23 +204,20 @@ class PolestarSensorDescription(
device_class=SensorDeviceClass.TIMESTAMP,
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="registration_number",
name="Registration Number",
icon="mdi:numeric-1-box",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="internal_vehicle_id",
name="Internal Vehicle ID",
icon="mdi:numeric-1-box",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
entity_registry_enabled_default=False,
),
PolestarSensorDescription(
Expand All @@ -247,15 +228,13 @@ class PolestarSensorDescription(
round_digits=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DURATION,
max_value=None,
),
PolestarSensorDescription(
key="model_name",
name="Model Name",
icon="mdi:car-electric",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="last_updated_odometer_data",
Expand All @@ -266,7 +245,6 @@ class PolestarSensorDescription(
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.TIMESTAMP,
entity_category=EntityCategory.DIAGNOSTIC,
max_value=None,
),
PolestarSensorDescription(
key="last_updated_battery_data",
Expand All @@ -277,7 +255,6 @@ class PolestarSensorDescription(
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.TIMESTAMP,
entity_category=EntityCategory.DIAGNOSTIC,
max_value=None,
),
PolestarSensorDescription(
key="estimate_full_charge_range",
Expand All @@ -288,15 +265,13 @@ class PolestarSensorDescription(
round_digits=None,
state_class=SensorStateClass.MEASUREMENT,
device_class=SensorDeviceClass.DISTANCE,
max_value=660, # WLTP range max 655
),
PolestarSensorDescription(
key="api_status_code_data",
name="API Status Code (Data)",
icon="mdi:heart",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False,
),
Expand All @@ -306,7 +281,6 @@ class PolestarSensorDescription(
icon="mdi:heart",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False,
),
Expand All @@ -316,7 +290,6 @@ class PolestarSensorDescription(
icon="mdi:clock-time-eight",
native_unit_of_measurement=None,
round_digits=None,
max_value=None,
entity_category=EntityCategory.DIAGNOSTIC,
entity_registry_enabled_default=False,
),
Expand All @@ -326,7 +299,6 @@ class PolestarSensorDescription(
icon="mdi:card-account-details",
native_unit_of_measurement="Nm",
round_digits=None,
max_value=None,
),
PolestarSensorDescription(
key="battery_capacity",
Expand All @@ -335,7 +307,6 @@ class PolestarSensorDescription(
native_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR,
suggested_display_precision=0,
round_digits=None,
max_value=None,
state_class=SensorStateClass.TOTAL,
device_class=SensorDeviceClass.ENERGY,
),
Expand Down Expand Up @@ -480,30 +451,6 @@ def state(self) -> StateType:
self._sensor_option_unit_of_measurement
)

if self.entity_description.key in (
"estimate_range",
"estimate_full_charge_range",
):
if self._sensor_option_unit_of_measurement == UnitOfLength.MILES:
self.entity_description.max_value = 410
elif self._sensor_option_unit_of_measurement == UnitOfLength.KILOMETERS:
self.entity_description.max_value = 660
elif self._sensor_option_unit_of_measurement == UnitOfLength.METERS:
self.entity_description.max_value = 660000

# prevent exponentianal value, we only give state value that is lower than the max value
if self.entity_description.max_value is not None:
if isinstance(self._sensor_data, str):
self._attr_native_value = int(self._sensor_data)
if self._attr_native_value > self.entity_description.max_value:
_LOGGER.warning(
"%s: Value %s is higher than max value %s",
self.entity_description.key,
self._attr_native_value,
self.entity_description.max_value,
)
return None

# only round value if native value is not None
if self._attr_native_value: # noqa
# round the value
Expand Down

0 comments on commit 131680e

Please sign in to comment.