Remove round digits

[jschlyter]

Rounding digits now handled via models. Includes #258, will rebase later before merge.

Summary by CodeRabbit

• New Features

  • Simplified sensor descriptions by removing unnecessary attributes, leading to a more straightforward implementation.
  • Streamlined odometer data update process for improved clarity and efficiency.

• Bug Fixes

  • Adjusted sensor value processing by eliminating redundant parameters, which may enhance performance and reliability.

[coderabbitai]

Walkthrough

The changes involve the modification of the PolestarSensorDescription class in the sensor.py file. The PolestarSensorDescriptionMixin has been removed, along with its attribute round_digits. As a result, PolestarSensorDescription now directly inherits from SensorEntityDescription. This simplification affects how sensor descriptions are instantiated in the POLESTAR_SENSOR_TYPES tuple and removes associated logic from the PolestarSensor class. The async_update method remains unchanged. Additionally, the update_odometer method in the PolestarCar class has been streamlined by simplifying the assignment of average speed.

Changes

File Path	Change Summary
custom_components/polestar_api/sensor.py	Removed PolestarSensorDescriptionMixin and its round_digits attribute; updated PolestarSensorDescription to inherit directly from SensorEntityDescription. Removed round_digits from POLESTAR_SENSOR_TYPES.
custom_components/polestar_api/polestar.py	Simplified update_odometer method in PolestarCar class by directly assigning data.average_speed_km_per_hour to self.data['average_speed'].

Possibly related PRs

• Remove handling of max value #258: The changes in this PR also modify the PolestarSensorDescription class by removing attributes related to sensor definitions, specifically the max_value attribute, which aligns with the simplification efforts seen in the main PR.

Suggested reviewers

• BJReplay

Poem

In the code where sensors play,
A mixin's gone, it’s a brighter day!
No more rounding, no max to bind,
Simpler paths for us to find.
Hopping through lines, oh what a sight,
With clearer flows, our code takes flight! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b6e9f2 and 0852c28.

📒 Files selected for processing (2)

• custom_components/polestar_api/polestar.py (1 hunks)
• custom_components/polestar_api/sensor.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• custom_components/polestar_api/polestar.py
• custom_components/polestar_api/sensor.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jschlyter]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[BJReplay]

Note desk review only for this and #258 as I have a funeral to attend today (and a long drive in the new car) but both look good.