Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use refresh token #40

Merged
merged 1 commit into from
Dec 31, 2023
Merged

use refresh token #40

merged 1 commit into from
Dec 31, 2023

Conversation

jyrkih
Copy link
Contributor

@jyrkih jyrkih commented Dec 27, 2023

Fixes issue #1, utilizes refresh token. Request for refreshing access token is authenticated, so refresh needs to happen while access token is valid. Thus 300 second grace period before token expiration.

@leeyuentuen leeyuentuen changed the base branch from main to dev December 27, 2023 14:44
@leeyuentuen
Copy link
Contributor

@jyrkih can you fix them that can merge to dev branch?

@leeyuentuen
Copy link
Contributor

leeyuentuen commented Dec 27, 2023

on your local,

git remote add upstream leeyuentuen/polestar_api
git fetch upstream
git checkout dev
git merge upstream/dev

solve the conflict
and then

git commit the code

or
github said this

Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b jyrkih-refresh-token dev
git pull [email protected]:jyrkih/polestar_api.git refresh-token
Step 2: Merge the changes and update on GitHub.

git checkout dev
git merge --no-ff jyrkih-refresh-token
git push origin dev

@leeyuentuen leeyuentuen changed the base branch from dev to tmpMaster December 31, 2023 11:08
@leeyuentuen leeyuentuen changed the base branch from tmpMaster to dev December 31, 2023 11:09
@leeyuentuen leeyuentuen merged commit 0dc179e into pypolestar:dev Dec 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants