Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Params for Rule add_export.py #331

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Add Params for Rule add_export.py #331

merged 4 commits into from
Jun 12, 2024

Conversation

Eddy-JV
Copy link
Collaborator

@Eddy-JV Eddy-JV commented Jun 11, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

This PR is part of adding Params to all Rules in Snakemake under Issue #330

The following Rules are already done including the work done in this PR:

  • add_export.py
    build_base_energy_totals.py
    build_base_industry_totals.py
    build_clustered_population_layouts.py
    build_cop_profiles.py
    build_heat_demand.py
    build_industrial_database.py
    build_industrial_distribution_key.py
    build_industry_demand.py
    build_population_layouts.py
    build_ship_profile.py
    build_solar_thermal_profiles.py
    build_temperature_profiles.py
    copy_config.py
    helpers.py
    make_summary.py
    override_respot.py
    plot_network.py
    plot_network_eur.py
    plot_summary.py
    prepare_airports.py
    prepare_db.py
    prepare_energy_totals.py
    prepare_gas_network.py
    prepare_heat_data.py
    prepare_ports.py
    prepare_sector_network.py
    prepare_transport_data.py
    prepare_transport_data_input.py
    prepare_urban_percent.py
    solve_network.py

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@Eddy-JV Eddy-JV requested a review from energyLS June 11, 2024 08:32
@Eddy-JV Eddy-JV self-assigned this Jun 11, 2024
Copy link
Collaborator

@energyLS energyLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark, please clarify

Snakefile Outdated
store_capital_costs=config["export"]["store_capital_costs"],
export_profile=config["export"]["export_profile"],
snapshots=config["snapshots"],
USD2013_to_EUR2013=config["costs"]["USD2013_to_EUR2013"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have numbers as variable names, is that an issue for snakemake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're right. The color is brown. Then I would use USD_to_EUR=

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eddy-JV yes, I agree

@Eddy-JV Eddy-JV merged commit 08470fc into main Jun 12, 2024
5 checks passed
@Eddy-JV Eddy-JV deleted the Params_add_export branch June 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants