Update on the RENAME PDF extension #2485
Conversation
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
...tension/pyRevit.tab/Drawing Set.panel/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py
Outdated
Show resolved
Hide resolved
jmcouffin
changed the title
|
I think I have made all the requested modifications! |
There was a problem hiding this comment.
@Malouche-git thanks for the the edits, it looks good now.
I didn't test it, @jmcouffin do you have the chance to check if it works?
If you can and it's ok let me know, I'll take care of the merge (I would like to try something to avoid too much pollution in the git history)
I modify the regex command and add a subfolder handler
…l/Sheets.pulldown/Rename PDF Sheets.pushbutton/script.py Co-authored-by: Andrea Ghensi <[email protected]>
sanzoghenzo
force-pushed
the
RENAME-PDF-Malouche-git-v1
branch
from
9817827 to
9f497f1
Compare
|
Interesting, the CI failed with the same errors as my environment... @jmcouffin I saw that you updated the submodules, what where the changes on them? could it be that you reverted to an old commit? |
I don't think I have. |
Oups, i think this is the one. I am not in front of my computer now, can revert tomorrow if needed @sanzoghenzo |
Took me some time but I managed to revert them! |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25009+2113-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1021-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25010+1128-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1201-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1638-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1855-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25013+1857-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1341-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25015+1357-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1520-wip |
|
📦 New work-in-progress (wip) builds are available for 5.0.0.25024+1957-wip |
Hello everyone !
it's my first pull request Pyrevit 🎉
It resolves issue #2273
Thank's @sanzoghenzo for the help and the warm welcome !
I modified the regex to manage different cases of spaces between hyphen and to normalize all hyphen in the new pdf name.
I also add a subfolder handler and some verification on the new name (empty or already existing)
I hope it's ok
Thanks, everyone, for the effort you put in !