-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detections): add bboxes column to detection and a route to fetch unacknowledged ones #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! High level question:
@MateoLostanlen @pyronear/front-end what is the minimal necessary information we need about unacknowledged détections?
I think it's a fallback until we have proper notification system. But let's make sure we get the exact thing right:
- do we plan on letting users specify a time range?
- if not, what's the time range? Last 24hours? Longer?
- if there are too many (and there will), how many should we keep and in which order should they be? (The N latest, the N oldest)
src/migrations/versions/2024_06_17_1521-4265426f8438_create_stes_table.py
Show resolved
Hide resolved
d41aa96
to
2cc5fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a few comments!
Here is a recap, after modifications, of what the PR introduces:
|
cf. #304 |
Add the acknowledged boolean in the table Detection and a new endpoint. It will allow the plateform to know if a Detection has been acknowledged by a User.