Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detections): add bboxes column to detection and a route to fetch unacknowledged ones #340

Merged
merged 65 commits into from
Aug 23, 2024

Conversation

RonanMorgan
Copy link
Collaborator

Add the acknowledged boolean in the table Detection and a new endpoint. It will allow the plateform to know if a Detection has been acknowledged by a User.

@RonanMorgan RonanMorgan self-assigned this Jul 4, 2024
@RonanMorgan RonanMorgan requested a review from frgfm July 4, 2024 19:24
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! High level question:
@MateoLostanlen @pyronear/front-end what is the minimal necessary information we need about unacknowledged détections?

I think it's a fallback until we have proper notification system. But let's make sure we get the exact thing right:

  • do we plan on letting users specify a time range?
  • if not, what's the time range? Last 24hours? Longer?
  • if there are too many (and there will), how many should we keep and in which order should they be? (The N latest, the N oldest)

@RonanMorgan RonanMorgan force-pushed the rs/add-acknowledged branch from d41aa96 to 2cc5fc0 Compare July 11, 2024 19:38
@RonanMorgan RonanMorgan requested a review from frgfm July 12, 2024 08:31
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few comments!

@RonanMorgan RonanMorgan requested a review from frgfm July 12, 2024 21:37
@frgfm frgfm changed the title Refactor Detections : Add acknowledged endpoint and localization parameter feat(detections): add bboxes column to detection and a route to fetch unacknowledged ones Aug 23, 2024
@frgfm
Copy link
Member

frgfm commented Aug 23, 2024

Here is a recap, after modifications, of what the PR introduces:

  • add a "bboxes" string column in the detections table, regex verified to avoid troubles
  • add a route to fetch unlabeled detections
  • update the client accordingly, and add a fetch_unlabeled_detections method
  • update client, backend & e2e tests accordingly
  • for migrations, only a minor fix, we'll create a clean one once we have enough to release & deploy (better to have 1 migration per production deploy)

@frgfm frgfm added this to the 0.2.0 milestone Aug 23, 2024
@frgfm frgfm merged commit dec9923 into main Aug 23, 2024
26 of 29 checks passed
@frgfm frgfm deleted the rs/add-acknowledged branch August 23, 2024 18:32
@frgfm
Copy link
Member

frgfm commented Aug 24, 2024

cf. #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants