Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :the admin behavior for bucket requests #343

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

RonanMorgan
Copy link
Collaborator

If you are connected as an admin, the bucket par defaut is "admin" but the endpoint Detection was using the "alert-api-1" name.

Anyway we should not use any of this two solutions when requesting for an URL, we need to use the Detection_id instead

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (rs/use-organization-bucket@5c492a5). Learn more about missing BASE report.

Files Patch % Lines
src/app/api/api_v1/endpoints/detections.py 75.00% 1 Missing ⚠️
src/app/services/storage.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             rs/use-organization-bucket     #343   +/-   ##
=============================================================
  Coverage                              ?   82.88%           
=============================================================
  Files                                 ?       31           
  Lines                                 ?      818           
  Branches                              ?        0           
=============================================================
  Hits                                  ?      678           
  Misses                                ?      140           
  Partials                              ?        0           
Flag Coverage Δ
backend 82.98% <60.00%> (?)
client 81.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm
Copy link
Member

frgfm commented Jul 11, 2024

I'm a bit lost here: would it be possible to directly put those commits in the bucket/org PR?

@RonanMorgan RonanMorgan merged commit 5d22609 into rs/use-organization-bucket Jul 11, 2024
25 of 27 checks passed
@RonanMorgan RonanMorgan deleted the rs/fix-detection-url branch July 11, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants