Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): make storage robust to edge case on region selection #407

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Jan 15, 2025

This PR changes the image used for localstack in dev environment.

We were using localstack/localstack:1.4.0, which is both outdated (2 years ago, not ideal for security) and too big (includes all AWS services, while we only need file storage). The new image is about 100Mb, vs. 750Mb previously

UPDATE: there is almost no documentation for the s3-latest minimal image (https://discuss.localstack.cloud/t/set-up-s3-bucket-using-docker-compose/646/2), so I'll just update localstack image which got smaller with recent releases : 450Mb vs 750Mb on our current image.

(The end-to-end test script ensures the behaviour hasn't changed)

Several difficulties with localstack, adding articles for reference:

EDIT: I reverted back to 1.4.0, and fixed the issues that weren't already detected by extending the tests

@frgfm frgfm added the type: improvement New feature or request label Jan 15, 2025
@frgfm frgfm self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (abce184) to head (21e590e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   84.83%   84.85%   +0.01%     
==========================================
  Files          35       35              
  Lines         996      997       +1     
==========================================
+ Hits          845      846       +1     
  Misses        151      151              
Flag Coverage Δ
backend 84.36% <100.00%> (+0.01%) ⬆️
client 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm changed the title perf(docker): use s3-only image from localstack perf(docker): bump localstack from 1.4.0 to 4.0.3 Jan 15, 2025
@frgfm frgfm changed the title perf(docker): bump localstack from 1.4.0 to 4.0.3 fix(storage): make storage robust to edge case on region selection Jan 15, 2025
@frgfm frgfm marked this pull request as ready for review January 15, 2025 16:30
@frgfm frgfm merged commit ca49671 into main Jan 15, 2025
27 checks passed
@frgfm frgfm deleted the frgfm/localstack-s3 branch January 15, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant