fix(storage): make storage robust to edge case on region selection #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the image used for localstack in dev environment.
We were using
localstack/localstack:1.4.0
, which is both outdated (2 years ago, not ideal for security) and too big (includes all AWS services, while we only need file storage). The new image is about 100Mb, vs. 750Mb previouslyUPDATE: there is almost no documentation for the s3-latest minimal image (https://discuss.localstack.cloud/t/set-up-s3-bucket-using-docker-compose/646/2), so I'll just update localstack image which got smaller with recent releases : 450Mb vs 750Mb on our current image.
(The end-to-end test script ensures the behaviour hasn't changed)
Several difficulties with localstack, adding articles for reference:
EDIT: I reverted back to 1.4.0, and fixed the issues that weren't already detected by extending the tests