Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #421

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update CONTRIBUTING.md #421

merged 1 commit into from
Jan 28, 2025

Conversation

fe51
Copy link
Member

@fe51 fe51 commented Jan 28, 2025

Noticed that DBDiagram is not up to date.

This PR replaces the DBDiagram with one that seems more recent https://dbdiagram.io/d/Pyronear-Alert-Schema-671e1b9897a66db9a3673d76

Happy to discuss it !

@github-actions github-actions bot added the topic: docs Improvements or additions to documentation label Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (83befb6) to head (1ede018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          38       38           
  Lines        1097     1097           
=======================================
  Hits          935      935           
  Misses        162      162           
Flag Coverage Δ
backend 84.57% <ø> (ø)
client 93.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm self-assigned this Jan 28, 2025
@frgfm frgfm added the type: improvement New feature or request label Jan 28, 2025
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@frgfm
Copy link
Member

frgfm commented Jan 28, 2025

cf. #422 (I don't think this everything mentioned there so not closing the issue for now)

@frgfm frgfm merged commit d70b389 into main Jan 28, 2025
28 checks passed
@frgfm frgfm deleted the DBDdiagram-url branch January 28, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: docs Improvements or additions to documentation type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants