Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): enforce fetch results to be ordered by ID #426

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Feb 10, 2025

This PR enforces ordering by ID for fetch commands. This changes the order on the camera fetching and detection fetching routes

Close #425

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (d70b389) to head (6475624).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/app/api/api_v1/endpoints/detections.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          38       38           
  Lines        1097     1097           
=======================================
  Hits          935      935           
  Misses        162      162           
Flag Coverage Δ
backend 84.57% <50.00%> (ø)
client 93.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! LGTM

@frgfm frgfm marked this pull request as ready for review February 10, 2025 13:19
@frgfm frgfm merged commit d7a84bf into main Feb 10, 2025
27 of 28 checks passed
@frgfm frgfm deleted the frgfm/fetch-order branch February 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering output
2 participants