Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix use of input model_path in the engine #244

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

theocayla
Copy link
Collaborator

  • Fix the use of model_path as input to instantiate the Engine
  • Add checks on the model_path and onnx load

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (5beb84c) to head (9c5b677).

Files with missing lines Patch % Lines
pyroengine/vision.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    89.15%   88.08%   -1.07%     
===========================================
  Files            6        6              
  Lines          627      638      +11     
===========================================
+ Hits           559      562       +3     
- Misses          68       76       +8     
Flag Coverage Δ
unittests 88.08% <27.27%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocayla theocayla changed the title Fix use of input model_path in the engine [WIP] Fix use of input model_path in the engine Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant