Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/TST: Fix external RC tests, add mac testing, bump NEP29 numpy #124

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

jklenzing
Copy link
Member

Description

Updates tests for external optional installs, partially in support of aburrell/aacgmv2#93.

  • Fixes a bug where the pre-release candidates are not downloaded
  • Adds support for mac tests for the external RC workflow
  • Bumps minimum numpy to 1.25 for NEP29 tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

via manual workflow initiated here and verifying that

  • aacgmv2 2.7.0rc1 is installed
  • the optional test test_methods_magcoord.py::TestBasics::test_add_coordinates[add_aacgm_coordinates-targets0] is run and passed

Test Configuration

  • Operating system: Mac, ubuntu, windows
  • Version number: Python 3.12

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing mentioned this pull request Dec 30, 2024
19 tasks
@jklenzing jklenzing requested a review from aburrell December 30, 2024 19:16
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart workflow!

@jklenzing jklenzing merged commit 664aac1 into develop Dec 30, 2024
25 of 31 checks passed
@jklenzing jklenzing deleted the tst/external_test_mac branch December 31, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants