-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: testing standards #130
Conversation
Test failure due to issue previously documents as #128. We could potentially put in a version limit (pysatNASA<=0.0.4) until the situation is sorted out. |
pysatNASA 0.0.5 is required to run on the operational system. As far as the version caps go, where do you want this to fail? |
| ------------------ | ------------------ | | ||
| numpy | pyForecastTools | | ||
| pandas >= 1.4.0 | pysat >= 3.0.4 | | ||
| requests | pysatNASA <= 0.0.4 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the higher cap.
Co-authored-by: Angeline Burrell <[email protected]>
OK, I have a local fix that will fix pysatNASA in the next release (pending another pull here). Options for the meantime are:
Preference? |
Let's go with: "Keep the version cap for now, and the operational version will just not run (old numpy incompatibility)" |
The local fix is up at #132, using the pysatNASA branch at pysat/pysatNASA#209 |
In which case, this is ready for review |
Description
Addresses #127, pysat roadmap
Updates pytest standards by removing
nose
syntax, which will be removed in a future version.Also updates the instrument test class usage, which will be updated in pysat 3.2.0.
The line "Updated tests to new pysat and pytest standards" in the changelog seems to describe these changes.
Type of change
How Has This Been Tested?
Via github actions and locally using pytest
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release