Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: testing standards #130

Merged
merged 5 commits into from
Oct 5, 2023
Merged

MAINT: testing standards #130

merged 5 commits into from
Oct 5, 2023

Conversation

jklenzing
Copy link
Member

Description

Addresses #127, pysat roadmap

Updates pytest standards by removing nose syntax, which will be removed in a future version.

Also updates the instrument test class usage, which will be updated in pysat 3.2.0.

The line "Updated tests to new pysat and pytest standards" in the changelog seems to describe these changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Via github actions and locally using pytest

Test Configuration:

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing linked an issue Oct 3, 2023 that may be closed by this pull request
@jklenzing jklenzing changed the title Maint/nose dep MAINT: testing standards Oct 3, 2023
@jklenzing
Copy link
Member Author

jklenzing commented Oct 3, 2023

Test failure due to issue previously documents as #128. We could potentially put in a version limit (pysatNASA<=0.0.4) until the situation is sorted out.

@jklenzing
Copy link
Member Author

pysatNASA 0.0.5 is required to run on the operational system. As far as the version caps go, where do you want this to fail?

@jklenzing jklenzing marked this pull request as ready for review October 4, 2023 15:23
@jklenzing jklenzing requested a review from aburrell October 4, 2023 15:23
| ------------------ | ------------------ |
| numpy | pyForecastTools |
| pandas >= 1.4.0 | pysat >= 3.0.4 |
| requests | pysatNASA <= 0.0.4 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the higher cap.

CHANGELOG.md Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
Co-authored-by: Angeline Burrell <[email protected]>
@jklenzing jklenzing requested a review from aburrell October 4, 2023 17:01
@jklenzing
Copy link
Member Author

OK, I have a local fix that will fix pysatNASA in the next release (pending another pull here). Options for the meantime are:

  • Keep the version cap for now, and the operational version will just not run (old numpy incompatibility)
  • Remove the version cap. All workflows will run, but one test will always fail.

Preference?

@aburrell
Copy link
Member

aburrell commented Oct 5, 2023

Let's go with: "Keep the version cap for now, and the operational version will just not run (old numpy incompatibility)"

@jklenzing
Copy link
Member Author

jklenzing commented Oct 5, 2023

The local fix is up at #132, using the pysatNASA branch at pysat/pysatNASA#209

@jklenzing
Copy link
Member Author

Let's go with: "Keep the version cap for now, and the operational version will just not run (old numpy incompatibility)"

In which case, this is ready for review

@jklenzing jklenzing merged commit 07f7640 into develop Oct 5, 2023
14 of 16 checks passed
@jklenzing jklenzing deleted the maint/nose_dep branch October 5, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: pytest deprecation of nose syntax
2 participants