Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: version cap on numpy #141

Merged
merged 3 commits into from
Dec 22, 2022
Merged

STY: version cap on numpy #141

merged 3 commits into from
Dec 22, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Dec 21, 2022

Description

The cdf interface doesn't like numpy 1.24.0. I see some issues with both cdflib and pysatCDF. Adds a version cap here to fix this for the time being.

Specific failures documented at #142 and pysat/pysatCDF#46

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Github Actions and local tests.

Test Configuration

Github Actions suite.

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing marked this pull request as ready for review December 21, 2022 19:55
@jklenzing jklenzing requested a review from rstoneback December 21, 2022 19:55
CHANGELOG.md Outdated Show resolved Hide resolved
@jklenzing jklenzing requested a review from aburrell December 21, 2022 20:09
@jklenzing jklenzing merged commit e8573bb into develop Dec 22, 2022
@jklenzing jklenzing deleted the jklenzing-patch-1 branch December 22, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants