Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: use standard init routines #202

Merged
merged 4 commits into from
Sep 8, 2023
Merged

STY: use standard init routines #202

merged 4 commits into from
Sep 8, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Sep 7, 2023

Description

Addresses #121

  • Moves acknowledgement string and references to methods files for all (non-deprecated) instruments.
  • Uses standard init routine for other methods
  • Updates references for new calibration of ISS FPMU data

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Instantiating instruments and printing refs:

import pysat
fpmu = pysat.Instrument('iss', 'fpmu')
print(fpmu.references)

Test Configuration:

  • Operating system: Monterrey
  • Version number: Python 3.9.7

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing added this to the 0.1.0 Release milestone Sep 7, 2023
@jklenzing jklenzing linked an issue Sep 7, 2023 that may be closed by this pull request
@jklenzing jklenzing added the style label Sep 7, 2023
@jklenzing jklenzing requested a review from aburrell September 7, 2023 15:28
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changelog comments seem to use past tense, so updated to be consistent with that.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Angeline Burrell <[email protected]>
@jklenzing jklenzing requested a review from aburrell September 7, 2023 20:27
@jklenzing jklenzing merged commit e94a5a1 into develop Sep 8, 2023
18 checks passed
@jklenzing jklenzing deleted the sty/121_refs branch September 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STY: standardize instrument reference and acknowledgements
2 participants