Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: cleaning routine #203

Merged
merged 5 commits into from
Sep 7, 2023
Merged

BUG: cleaning routine #203

merged 5 commits into from
Sep 7, 2023

Conversation

jklenzing
Copy link
Member

Description

The maven insitu data is having an issue with the general cleaning routine. This is because it includes transformation matrics that have symmetric dimensions, ie ('time', 'compno_3', 'compno_3'). xarray doesn't like this. Since it doesn't make sense to clean the transformation matrices (similar to coords), we place a check in the clean routine to skip over these.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

loading maven insitu data

Test Configuration:

  • Operating system: Monterrey
  • Version number: Python 3.9.7

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing added the bug Something isn't working label Sep 7, 2023
@jklenzing jklenzing marked this pull request as ready for review September 7, 2023 16:45
@jklenzing jklenzing requested a review from t-esman September 7, 2023 16:45
@jklenzing jklenzing merged commit 6f44f57 into maven_mgs Sep 7, 2023
18 checks passed
@jklenzing jklenzing deleted the maven_mgs_jk branch September 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants