Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: routines for omni #205

Merged
merged 10 commits into from
Sep 8, 2023
Merged

TST: routines for omni #205

merged 10 commits into from
Sep 8, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Sep 7, 2023

Description

Addresses #34

  • Tests remaining omni custom methods.
  • Adds a version minimum for scipy.
  • Fixed a bug in calculate_imf_steadiness, new window was calculated as float, incurring the wrath of pandas 🐼

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

new unit tests

Test Configuration:

  • Operating system: Monterrey
  • Version number: Python 3.9.7

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing linked an issue Sep 7, 2023 that may be closed by this pull request
5 tasks
@jklenzing jklenzing added this to the 0.1.0 Release milestone Sep 7, 2023
@jklenzing jklenzing added bug Something isn't working enhancement New feature or request labels Sep 7, 2023
@jklenzing jklenzing marked this pull request as ready for review September 7, 2023 22:49
@jklenzing jklenzing requested a review from aburrell September 7, 2023 22:50
CHANGELOG.md Outdated Show resolved Hide resolved
@jklenzing jklenzing merged commit 8e96fa7 into develop Sep 8, 2023
18 checks passed
@jklenzing jklenzing deleted the tst/34_omni branch September 8, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: specialized OMNI HRO routines need testing
2 participants