Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved init #210

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Improved init #210

merged 2 commits into from
Oct 5, 2023

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Oct 5, 2023

Description

On another project, I found out that metadata needs to be imported from importlib and can't be reliably called as a submodule by importing importlib. Added fixes here.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

python -c "import pysatNASA; print(pysatNASA.__version__)"

But sometimes this also works without the fix 🐞

Test Configuration:

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

Fixed init metadata by:
- moving all imports to top, and
- robustly importing metadata submodule.
Added the changes to the log.
@aburrell aburrell requested a review from jklenzing October 5, 2023 15:00
@aburrell aburrell merged commit 807d60d into develop Oct 5, 2023
18 checks passed
@aburrell aburrell deleted the improved_init branch October 5, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants