-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/MAINT: cdaweb downloads, ICON IVM-B tests, new flag to skip new tests #223
Conversation
Tests against pysat RC here: https://github.com/pysat/pysatNASA/actions/runs/7575679334 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the acronyms, so maybe they should be expanded, but that's your call. The code looks good 🦦
start = pysat.utils.time.filter_datetime_input(start) | ||
stop = pysat.utils.time.filter_datetime_input(stop) | ||
|
||
# CDAS WS needs a time for the stop date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does CDAS WS stand for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should change this to cdasws, which is the package name.
TODO:
|
…into bug/cdaweb_clean
On doc failure: SABER has added a human check to their websites. Moving the link to the comments so that the link check will skip this. |
Check the fix I made on the GUVI branch, it's a bit more "smart" |
Description
Addresses #218 (partial)
Fixes a major issue where
cdasws
ignores the end date for download requests if no data is present at 00:00:00 on the end date. This fixes most of the items in #218.Adds testing flags for upcoming pysat pull to ignore "new" tests for now while we update the ecosystem. Usage of flags includes TODO statements linked to the relevant issue.
Turns on tests for ICON IVM-B now that some data is public for that.
Type of change
How Has This Been Tested?
pytest using the
enh/test_triage
branch ofpysat
Test Configuration:
pysat
enh/test_triage branchChecklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release