Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/MAINT: cdaweb downloads, ICON IVM-B tests, new flag to skip new tests #223

Merged
merged 13 commits into from
Mar 5, 2024

Conversation

jklenzing
Copy link
Member

Description

Addresses #218 (partial)

Fixes a major issue where cdasws ignores the end date for download requests if no data is present at 00:00:00 on the end date. This fixes most of the items in #218.

Adds testing flags for upcoming pysat pull to ignore "new" tests for now while we update the ecosystem. Usage of flags includes TODO statements linked to the relevant issue.

Turns on tests for ICON IVM-B now that some data is public for that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

pytest using the enh/test_triage branch of pysat

Test Configuration:

  • Operating system: Ventura 3.6.1
  • Version number: Python 3.10.9
  • pysat enh/test_triage branch

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing
Copy link
Member Author

Tests against pysat RC here: https://github.com/pysat/pysatNASA/actions/runs/7575679334

@jklenzing jklenzing requested a review from aburrell January 31, 2024 20:58
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the acronyms, so maybe they should be expanded, but that's your call. The code looks good 🦦

start = pysat.utils.time.filter_datetime_input(start)
stop = pysat.utils.time.filter_datetime_input(stop)

# CDAS WS needs a time for the stop date.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does CDAS WS stand for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should change this to cdasws, which is the package name.

@jklenzing
Copy link
Member Author

jklenzing commented Feb 15, 2024

TODO:

  • run vs latest RC
  • update comment above

@jklenzing jklenzing mentioned this pull request Mar 5, 2024
11 tasks
@jklenzing
Copy link
Member Author

On doc failure: SABER has added a human check to their websites. Moving the link to the comments so that the link check will skip this.

@aburrell
Copy link
Member

aburrell commented Mar 5, 2024

Check the fix I made on the GUVI branch, it's a bit more "smart"

@jklenzing jklenzing merged commit 0b7d9b9 into develop Mar 5, 2024
21 of 23 checks passed
@jklenzing jklenzing deleted the bug/cdaweb_clean branch March 5, 2024 18:29
@jklenzing jklenzing mentioned this pull request Aug 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants