Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyscript version and improve template #140

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

FabioRosado
Copy link
Contributor

Changes to the template follow the one we have in PSDC

tests/test_cli.py Outdated Show resolved Hide resolved
@WebReflection
Copy link

to expand in one place about my comments, void elements never need /> as these are ... well, void elements, no XML like self-closing tag needed, as that's simply not supported in HTML5, so you could save some char and not propose a template that no IDE would generate automatically as meta, link, among others, don't need to be closed because can't accept child nodes: https://developer.mozilla.org/en-US/docs/Glossary/Void_element

@FabioRosado
Copy link
Contributor Author

Done thanks 😄

Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabioRosado FabioRosado merged commit 7675dae into pyscript:main Feb 29, 2024
7 checks passed
@FabioRosado FabioRosado deleted the fr/update-version branch February 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants