Fixes for Qt/PYSIDE-130 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes changes to TS parsing and saving, as well as the [Meta]TranslatorMessage data classes. The translator comment must be stored in the data model so that it is propagated through a "merge", but it is not part of the key used to identify a translation, so it is not involved in equality tests or comparisons.
This is a simple change to TS parsing and saving; no changes are required in the data model. Translation variants are simply concatenated with a special separating character, and Qt knows how to handle the display of the concatenated string.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits add support for the lengthvariant and translatorcomment tags currently lost by pyside-lupdate.