[WIP]: bytecode: add support for constant tuples #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add the test that exposed it. addGuard(obj) is dangerous because obj could be deallocated+reallocated in the same spot, which is what ended up happening here.
Hopefully this doesn't end up keeping things alive for too much extra time.
Since we are putting more things in the IC gc references, call GC again after clearing them.
Fix uses of addGuard(python_object)
- previously we never deregistered the EH frame from libunwind (which exposed a bug) - I removed the calls to register the EH info with gcc since we have our own unwinder which does not need this - cleaned up the code and fixed some small memory leaks
EH: correctly deregister EH frames and cleanup the code
we free now the code blocks after a recompile in the LLVM tier (except for OSR frames) because it is likely that we will not use the code anymore. - we have to make sure we are not currently executing any code we will delete that's why I added bjit_num_inside - there were some cases where we forgot to deregister stuff - when profiling we don't actually unmap the code in order to not brake profiling
free bjit code after LLVM codegen
We used to store the string content twice. This implementation makes use of DenseSet::find_as functionality where one can search using a different type. I was not sure if the special DenseMapInfo I had to create causes any problems so I choose to create a new source file for it so that it does not get picked up somewhere else.
this fixes the huge (~350MB) leak in:
for i in xrange(1000000):
class C(object):
pass
…asses hidden classes: free classes of singleton type
string interning: make it slightly more space efficient
switch from the SSE prefetch to __builtin_prefetch
This new version is causing some issues for us
It's time :(
Instead of having it always point to the thread-local threadstate object, it's a global that gets updated during context switches, like CPython does it. There are still a number of differences that should be refactored out, but I think this should bring us quite a bit closer to CPython's implementation.
Threading fixes to get cffi-1.7 working
this makes ENABLE_SIGNAL_CHECKING 0 work again
createAfter: don't crash when BB is empty
- this transforms all stores from 64bit to 32bit
- but more importantly removes a lot of embedded pointers and replaces them with constant integers which lets llvm use smaller opcodes.
- had to teach our assembler how to generate 32bit stores
django_template3.py 2.4s (6) 2.4s (4) +0.3%
pyxl_bench.py 2.1s (6) 2.1s (4) -1.9%
sqlalchemy_imperative2.py 2.6s (6) 2.5s (4) -1.2%
pyxl_bench2.py 1.1s (6) 1.1s (4) -1.9%
pyxl_bench_10x.py 16.7s (6) 16.5s (4) -1.4%
django_template3_10x.py 11.8s (6) 11.5s (4) -3.0%
sqlalchemy_imperative2_10x.py 18.0s (6) 17.9s (4) -0.4%
pyxl_bench2_10x.py 9.3s (6) 8.8s (4) -5.1%
geomean 5.1s 5.0s -1.8%
FrameInfo: store current statement as offset from the bytecode start
Previously if we called `embedRelocatablePtr` twice on the same pointer value we would get two different GVs. But llvm assumes that the addresses of two different syms can't be the equal. This caused some of the `is` checks to fail.
llvm JIT: better handling of `const is const` & less unboxing calls
undingen
force-pushed
the
const_tuple_bst3
branch
from
b6846e7 to
8fb4cb5
Compare
this was only a very small leak
ParamNames: don't leak BST_Name nodes
update to cpython 2.7.8
CodeConstants: own all constants and cleanup code
undingen
force-pushed
the
const_tuple_bst3
branch
from
74a4986 to
2f471db
Compare
Pyston can not support _PyObject_GetDictPtr properly. So add PyObject_GetDictCopy, PyObject_ClearDict, PyObject_UpdateDict API. The PyObject_GetDictCopy only return an copy of object's dict, not a writable dict pointer like _PyObject_GetDictPtr. The PyObject_UpdateDict only update or append new key-value pairs from new dict. It will not reset object's dict if the key is not existed in the new dict.
Some small fixings
llvm tier: inline invoke instructions
undingen
force-pushed
the
const_tuple_bst3
branch
from
5bd535a to
d8c3bb9
Compare
undingen
force-pushed
the
const_tuple_bst3
branch
from
d8c3bb9 to
b56021f
Compare
kmod
force-pushed
the
master
branch
2 times, most recently
from
352fd89 to
6488a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.