Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PY3.12 Support to build #128

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Adding PY3.12 Support to build #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build_wheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2022, macos-12]
pyver: [cp38, cp39, cp310, cp311]
pyver: [cp38, cp39, cp310, cp311, cp312]

steps:
- name: Checkout repo
Expand All @@ -64,14 +64,14 @@ jobs:
CIBW_BEFORE_TEST: pip install -r {package}/test-requirements.txt
# mac needs ninja to build
CIBW_BEFORE_BUILD_MACOS: brew install ninja
# configure cibuildwheel to build native archs ('auto'), and some emulated ones
# configure cibuildwheel to build native archs ('auto'), and some emulated ones
CIBW_ARCHS_LINUX: x86_64
CIBW_ARCHS_WINDOWS: AMD64
CIBW_ARCHS_MACOS: x86_64
# only build current supported python: https://devguide.python.org/versions/
# don't build pypy or musllinux to save build time. TODO: find a good way to support those archs
CIBW_BUILD: ${{matrix.pyver}}-*
CIBW_SKIP: cp36-* cp37-* cp312-* pp* *-musllinux*
CIBW_SKIP: cp36-* cp37-* pp* *-musllinux*
# Will avoid testing on emulated architectures
# Skip trying to test arm64 builds on Intel Macs
CIBW_TEST_SKIP: "*-*linux_{aarch64,ppc64le,s390x} *-macosx_arm64 *-macosx_universal2:arm64"
Expand All @@ -87,7 +87,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest,macos-12]
pyver: [cp38, cp39, cp310, cp311]
pyver: [cp38, cp39, cp310, cp311, cp312]

steps:
- name: Checkout repo
Expand All @@ -106,15 +106,15 @@ jobs:
with:
package-dir: ./swmm-toolkit
env:
# configure cibuildwheel to build native archs ('auto'), and some emulated ones
# configure cibuildwheel to build native archs ('auto'), and some emulated ones
CIBW_ARCHS_LINUX: aarch64
CIBW_ARCHS_MACOS: arm64
CIBW_ARCHS_MACOS: arm64
# only build current supported python: https://devguide.python.org/versions/
# don't build pypy or musllinux to save build time. TODO: find a good way to support those archs
CIBW_BUILD: ${{matrix.pyver}}-*
CIBW_SKIP: cp36-* cp37-* cp312-* pp* *-musllinux*
CIBW_SKIP: cp36-* cp37-* pp* *-musllinux*
CIBW_BUILD_VERBOSITY: 1

- uses: actions/upload-artifact@v3
with:
path: ./wheelhouse/*.whl
path: ./wheelhouse/*.whl
7 changes: 4 additions & 3 deletions swmm-toolkit/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,10 @@ def exclude_files(cmake_manifest):
cmake_args = cmake_args,
cmake_process_manifest_hook = exclude_files,

description='OWA SWMM Python Toolkit',
description='PySWMM SWMM Python Toolkit',
long_description=long_description,
long_description_content_type='text/markdown',
url='https://github.com/OpenWaterAnalytics/swmm-python',
url='https://github.com/pyswmm/swmm-python',

author='See AUTHORS',
maintainer_email='[email protected]',
Expand All @@ -145,7 +145,8 @@ def exclude_files(cmake_manifest):
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: C",
"Development Status :: 5 - Production/Stable",
]
)
)